Add missing mensural prolations to time signature properties dialog #31557
Conversation
|
Wouldn't we also need to make the symId names translatable? The missing ones were in, but commented out before 98464fd, which removed them. There are missing counterparts in src/framework/ui/view/musicalsymbolcodes.h (see your #9741) |
`mensuralProlation6` and `mensuralProlation9` were missing for seemingly no good reason. Also update the comments to match the SMuFL spec (don’t know if that makes them more accurate or not though) Resolves: #31553
cbjeukendrup
force-pushed
the
prolatione
branch
from
bdf6151 to
4446453
Compare
|
Thanks, it should be more complete now. |
|
Would you have SVGs for those 2 new icons? I'd need those in order to be able to add them to my 3.7 Edit: I've created them myself meanwhile, modified copies of the existing ones |
|
|
||
| fourfourButton->setStyleSheet(radioButtonStyle); | ||
| fourfourButton->setText(musicalSymbolToString(MusicalSymbolCodes::Code::TIMESIG_COMMON)); | ||
| fourfourButton->setMaximumHeight(30); |
There was a problem hiding this comment.
Maybe
fourfourButton->setToolTip(qApp->translate("symUserNames", "Common time"));
or
fourfourButton->setToolTip(qApp->translate("symUserNames", Sym::symUserNames[int(SymId::timeSigCommon)]));
| fourfourButton->setMaximumHeight(30); | ||
| allaBreveButton->setStyleSheet(radioButtonStyle); | ||
| allaBreveButton->setText(musicalSymbolToString(MusicalSymbolCodes::Code::TIMESIG_CUT)); | ||
| allaBreveButton->setMaximumHeight(30); |
There was a problem hiding this comment.
Maybe
allaBreveButton->setToolTip(qApp->translate("symUserNames", "Cut time"));
or
allaBreveButton->setToolTip(qApp->translate("symUserNames", Sym::symUserNames[int(SymId::timeSigCutCommon)]));
| for (SymId prolatio : prolatioList) { | ||
| const QString& str = symbolFont->toString(prolatio); | ||
| if (str.size() > 0) { | ||
| otherCombo->addItem(str, int(prolatio)); |
There was a problem hiding this comment.
Maybe
otherCombo->addItem(str, qApp->translate("symUserNames", Sym::symUserNames[int(protatio)]), int(prolatio));
or whatever the way in master is to do this. Maybe
otherCombo->addItem(str, SymNames::translatedUserNameForSymId(protatio), int(prolatio));
It works in 3.x and looks like this:
No idea whether/how toolTips would be possible too
Backport of musescore#31557 Todo: find and add the missing SVGs and add cut2 and cut3 to the timesig properties dialog
mensuralProlation6andmensuralProlation9were missing for seemingly no good reason.Also update the comments to match the SMuFL spec (don’t know if that makes them more accurate or not though)
Resolves: #31553